-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1909 hs.inspect table bug #1910
#1909 hs.inspect table bug #1910
Conversation
* Fixed bug with inspecting complex tables.
hs.inspect = require("hs.inspect") | ||
|
||
-- tests the case where a custom __init always returns a new table instance as a key/value | ||
function testInspectAlwaysNewTableKeyValue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(W111) setting non-standard global variable 'testInspectAlwaysNewTableKeyValue'
extensions/inspect/test_inspect.lua
Outdated
-- tests the case where a custom __init always returns a new table instance as a key/value | ||
function testInspectAlwaysNewTableKeyValue() | ||
local t = setmetatable({}, { | ||
__init = function(_, key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(W212) unused argument 'key'
* Fixed stickler issue
Good work for adding a test, but I think |
That would probably help :P I've pushed a fix. |
Merged with some changes (note that the name of the Lua test function has to match the name in ObjC if |
@cmsj - I think maybe something went wrong when you merged this? It seems you merged the test (then commented it out), but didn't actually merge the fix? |
@latenitefilms it looks to me like the fix from this PR is in So, I'm not sure what I missed? |
Opps, apologies, I must have been looking in a wrong branch. |
Fixes #1909.